Use of target type annotations as processing instruction#43
Merged
sjaakd merged 2 commits intomapstruct:masterfrom Nov 3, 2018
Merged
Use of target type annotations as processing instruction#43sjaakd merged 2 commits intomapstruct:masterfrom
sjaakd merged 2 commits intomapstruct:masterfrom
Conversation
chris922
reviewed
May 5, 2018
| } | ||
| } | ||
|
|
||
| @IgnoreMapping |
Member
There was a problem hiding this comment.
What's the reason for this qualifier? I can't find a place where it is used.
Member
There was a problem hiding this comment.
When a method is marked with a Qualifier MapStruct will not use it in the default options for choosing a method. Thus Sjaak called this @IgnoreMapping. This would mean that when mapping TaxRecord to TaxRecordPE only convert(LegalEntity s, @Context TaxContext ctx) would be considered as an option
Contributor
Author
There was a problem hiding this comment.
Maybe we can just mention that this uses reflection (we are usually reflection free 😄)
done. Also clarified / renamed the @IgnoreMapping
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This example demonstrates a few things:
@Contextand@BeforeMappingon context to store the target annotation information.@IgnoreAllannotation to make sure mapping methods are not directly triggered (@filiphr .. perhaps we should add this to MapStruct by default or document is as pattern.. I - for one - find it very usable.